-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URI for autoconfig test for specviz2d, add back specviz test #3267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me once ✅ 🤞 Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passed, thanks!
Something went wrong ... Please have a look at my logs. |
…viz2d, add back specviz test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3267 +/- ##
==========================================
+ Coverage 88.63% 88.78% +0.15%
==========================================
Files 125 125
Lines 18781 18832 +51
==========================================
+ Hits 16646 16720 +74
+ Misses 2135 2112 -23 ☔ View full report in Codecov by Sentry. |
The bot is refusing to work, so a manual backport will have to be done. |
Weird... Maybe you can just try manually open a PR from this branch and see. https://github.com/meeseeksmachine/jdaviz/tree/auto-backport-of-pr-3267-on-v4.0.x |
@meeseeksdev backport to v4.0.x |
Could not push to auto-backport-of-pr-3267-on-v4.0.x due to error, aborting. |
…7-on-v4.0.x Backport PR #3267: Fix URI for autoconfig test for specviz2d, add back specviz test
Description
Remote data tests are currently failing on a file lookup in MAST. This PR replaces that specific, unresolvable URI to one that works.
We had commented out a Specviz test, which I've added again, since #2576 was merged.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.