Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URI for autoconfig test for specviz2d, add back specviz test #3267

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented Nov 4, 2024

Description

Remote data tests are currently failing on a file lookup in MAST. This PR replaces that specific, unresolvable URI to one that works.

We had commented out a Specviz test, which I've added again, since #2576 was merged.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@bmorris3 bmorris3 added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤backport-v4.0.x on-merge: backport to v4.0.x labels Nov 4, 2024
@bmorris3 bmorris3 added this to the 4.0.1 milestone Nov 4, 2024
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me once ✅ 🤞 Thanks!

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed, thanks!

@pllim pllim merged commit 80298a3 into spacetelescope:main Nov 4, 2024
17 checks passed
Copy link

lumberbot-app bot commented Nov 4, 2024

Something went wrong ... Please have a look at my logs.

meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (b6bf280) to head (108070e).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3267      +/-   ##
==========================================
+ Coverage   88.63%   88.78%   +0.15%     
==========================================
  Files         125      125              
  Lines       18781    18832      +51     
==========================================
+ Hits        16646    16720      +74     
+ Misses       2135     2112      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim
Copy link
Contributor

pllim commented Nov 4, 2024

The bot is refusing to work, so a manual backport will have to be done.

@pllim
Copy link
Contributor

pllim commented Nov 4, 2024

Weird... Maybe you can just try manually open a PR from this branch and see.

https://github.com/meeseeksmachine/jdaviz/tree/auto-backport-of-pr-3267-on-v4.0.x

@pllim
Copy link
Contributor

pllim commented Nov 12, 2024

@meeseeksdev backport to v4.0.x

Copy link

lumberbot-app bot commented Nov 12, 2024

Could not push to auto-backport-of-pr-3267-on-v4.0.x due to error, aborting.

pllim added a commit that referenced this pull request Nov 13, 2024
…7-on-v4.0.x

Backport PR #3267: Fix URI for autoconfig test for specviz2d, add back specviz test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two 💤backport-v4.0.x on-merge: backport to v4.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants