-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated/stale code #3270
Conversation
.imviz div.v-card.v-card--flat.v-sheet.v-sheet--tile { | ||
/* black background beyond edges of canvas for canvas rotation */ | ||
background-color: black | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmorris3 - I vaguely remember this causing you troubles right? Was there anything we did to workaround it that could/should be undone here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't causing issues anymore, because we don't use canvas rotation. We now get a white background where there are no data from work starting in glue glue-viz/glue#2482, which was first used in jdaviz in #2671, and also used in the DQ layers. Removing this should (I hope) have no effect.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3270 +/- ##
==========================================
+ Coverage 88.76% 88.80% +0.04%
==========================================
Files 125 125
Lines 18963 18928 -35
==========================================
- Hits 16832 16809 -23
+ Misses 2131 2119 -12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks for cleaning up after #2878 . LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'cubeviz_ndarray_gif' notebook still has a reference to Export Plot, otherwise look good!
Has a conflict now. Please rebase. Thanks. |
6c1975b
to
a9c9171
Compare
Description
This pull request removes API access to plugins that have passed their deprecation period as well as stale code from the former canvas rotation plugin.
Related to:
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.