Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated/stale code #3270

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Nov 7, 2024

Description

This pull request removes API access to plugins that have passed their deprecation period as well as stale code from the former canvas rotation plugin.

Related to:

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 4.1 milestone Nov 7, 2024
@github-actions github-actions bot added embed Regarding issues with front-end embedding imviz plugin Label for plugins common to multiple configurations labels Nov 7, 2024
Comment on lines -84 to -79
.imviz div.v-card.v-card--flat.v-sheet.v-sheet--tile {
/* black background beyond edges of canvas for canvas rotation */
background-color: black
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorris3 - I vaguely remember this causing you troubles right? Was there anything we did to workaround it that could/should be undone here as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't causing issues anymore, because we don't use canvas rotation. We now get a white background where there are no data from work starting in glue glue-viz/glue#2482, which was first used in jdaviz in #2671, and also used in the DQ layers. Removing this should (I hope) have no effect.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (01553da) to head (a9c9171).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3270      +/-   ##
==========================================
+ Coverage   88.76%   88.80%   +0.04%     
==========================================
  Files         125      125              
  Lines       18963    18928      -35     
==========================================
- Hits        16832    16809      -23     
+ Misses       2131     2119      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review November 7, 2024 18:24
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for cleaning up after #2878 . LGTM. Thanks!

Copy link
Contributor

@cshanahan1 cshanahan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'cubeviz_ndarray_gif' notebook still has a reference to Export Plot, otherwise look good!

@kecnry kecnry requested a review from cshanahan1 November 13, 2024 21:32
@pllim
Copy link
Contributor

pllim commented Nov 14, 2024

Has a conflict now. Please rebase. Thanks.

@kecnry kecnry force-pushed the remove-deprecated-code branch from 6c1975b to a9c9171 Compare November 14, 2024 14:14
@pllim pllim merged commit be9180b into spacetelescope:main Nov 14, 2024
19 checks passed
@kecnry kecnry deleted the remove-deprecated-code branch November 14, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embed Regarding issues with front-end embedding imviz plugin Label for plugins common to multiple configurations Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants