Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full width of plugin slider #3303

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Nov 18, 2024

Description

This pull request ensures sliders in plugins use full-width. In the footprint plugin, where the slider was not wrapped in a glue sync state, the slider currently did not fill the full-width of the plugin.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

(affects footprints plugin)
@kecnry kecnry added UI/UX😍 trivial Only needs one approval instead of two 💤backport-v4.0.x on-merge: backport to v4.0.x labels Nov 18, 2024
@kecnry kecnry added this to the 4.0.1 milestone Nov 18, 2024
@kecnry kecnry marked this pull request as ready for review November 18, 2024 19:58
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (7e5ddfa) to head (e7f47f0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3303      +/-   ##
==========================================
- Coverage   88.81%   88.81%   -0.01%     
==========================================
  Files         125      125              
  Lines       19030    19036       +6     
==========================================
+ Hits        16901    16906       +5     
- Misses       2129     2130       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@kecnry kecnry merged commit 88d82f9 into spacetelescope:main Nov 19, 2024
19 checks passed
@kecnry kecnry deleted the slider-full-width branch November 19, 2024 16:28
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Nov 19, 2024
kecnry added a commit that referenced this pull request Nov 19, 2024
Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial Only needs one approval instead of two UI/UX😍 💤backport-v4.0.x on-merge: backport to v4.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants