Fix CI/RTD failures #3317
Merged
Fix CI/RTD failures #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
added
no-changelog-entry-needed
kecnry
requested review from
rosteen,
javerbukh,
pllim,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
|
Could you ignore the |
|
not 100% sure on the syntax, let's see if this still passes 🤞 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3317 +/- ##
=======================================
Coverage 88.81% 88.81%
=======================================
Files 125 125
Lines 19036 19036
=======================================
Hits 16906 16906
Misses 2130 2130 ☔ View full report in Codecov by Sentry. |
pllim
approved these changes
Nov 25, 2024
| @@ -138,6 +138,8 @@ filterwarnings = [ | |||
| "ignore::DeprecationWarning:glue", | |||
| "ignore::DeprecationWarning:asteval", | |||
| "ignore:::specutils.spectra.spectrum1d", | |||
| # Remove the following line once https://github.com/astrofrog/mpl-scatter-density/issues/46 is addressed | |||
| "ignore:pkg_resources is deprecated as an API:DeprecationWarning:mpl_scatter_density", | |||
There was a problem hiding this comment.
So we can have reminder, can use a cross link here:
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Nov 25, 2024
rosteen
added a commit
to rosteen/jdaviz
that referenced
this pull request
Nov 25, 2024
* Add intersphinx ref * ignore mpl_scatter_density deprecation warning * specify mpl_scatter_density only --------- Co-authored-by: Ricky O'Steen <rosteen@stsci.edu>
kecnry
added a commit
that referenced
this pull request
Nov 26, 2024
Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes recent upstream changes causing CI/RTD build failures.
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.