Backport PR #3309 on branch v4.0.x (raise error for sidecar or popout when not supported) #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en not supported
meeseeksmachine
requested review from
rosteen,
javerbukh,
pllim and
kecnry
as code owners
meeseeksmachine
requested review from
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
kecnry
approved these changes
Dec 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.0.x #3324 +/- ##
==========================================
- Coverage 88.65% 88.64% -0.01%
==========================================
Files 125 125
Lines 18794 18795 +1
==========================================
Hits 16661 16661
- Misses 2133 2134 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #3309: raise error for sidecar or popout when not supported