-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add get_subsets_as_regions method to subset plugin, deprecate get_interactive_regions and get_spectral_regions #3340
Conversation
I kept the scope in this ticket limited to consolidating functions that obtain subsets as regions all to the Subset Tools plugin in the new 'get_regions' method. There will be some follow up items to address: First, two items that are part of the bigger picture:
And second, some isolated follow up items:
|
811b940
to
703b6ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3340 +/- ##
==========================================
- Coverage 88.80% 88.70% -0.11%
==========================================
Files 125 125
Lines 19137 19206 +69
==========================================
+ Hits 16995 17037 +42
- Misses 2142 2169 +27 ☔ View full report in Codecov by Sentry. |
…y_interactive_region
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
This PR adds
get_regions
to the Subset Tools plugin, and deprecatesget_interactive_regions
andget_spectral_regions
.