Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Roman L2 notebook update since B16 #3346

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented Dec 10, 2024

Description

Updating the example files in the imviz_roman_asdf.ipynb concept notebook. I've also added an assert for the rad/roman_datamodels versions to catch mismatches between dependencies and the example data. cc @PaulHuwe

Fixes #3344

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@bmorris3 bmorris3 added this to the 4.0.1 milestone Dec 10, 2024
@github-actions github-actions bot added the documentation Explanation of code and concepts label Dec 10, 2024
@bmorris3 bmorris3 force-pushed the imviz-example-update branch from ad3f16a to cafb653 Compare December 10, 2024 19:46
@bmorris3 bmorris3 added the trivial Only needs one approval instead of two label Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (6c946d3) to head (2bd6a4a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3346   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files         125      125           
  Lines       19137    19137           
=======================================
  Hits        16995    16995           
  Misses       2142     2142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim added 💤backport-v4.0.x on-merge: backport to v4.0.x bug Something isn't working labels Dec 11, 2024
@pllim pllim merged commit cf9664f into spacetelescope:main Dec 11, 2024
30 of 31 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Dec 11, 2024
pllim added a commit that referenced this pull request Dec 11, 2024
…6-on-v4.0.x

Backport PR #3346 on branch v4.0.x (Example Roman L2 notebook update since B16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Explanation of code and concepts trivial Only needs one approval instead of two 💤backport-v4.0.x on-merge: backport to v4.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Roman Notebook Failing w/ Roman v17
3 participants