Fix type issue in plot options select_all #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshanahan1
requested review from
rosteen,
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay and
gibsongreen
as code owners
github-actions
bot
added
the
plugin
pllim
reviewed
Dec 18, 2024
jdaviz/configs/default/plugins/plot_options/tests/test_plot_options.py
Outdated
Show resolved
Hide resolved
pllim
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3366 +/- ##
==========================================
- Coverage 88.77% 88.76% -0.01%
==========================================
Files 125 125
Lines 19235 19246 +11
==========================================
+ Hits 17075 17083 +8
- Misses 2160 2163 +3 ☔ View full report in Codecov by Sentry. |
kecnry
reviewed
Dec 19, 2024
kecnry
reviewed
Dec 19, 2024
kecnry
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that came up when trying to select all layers in plot options when data is float32. The solution is to use the logic in on_glue_value_changed to handle updating mixed state, which takes care of the type issue.
(Need this fix for AAS demo notebook)