Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set stcal to main, allow python 3.13 #9105

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jan 29, 2025

Set stcal dependency to main and allow python 3.13 to allow the build sdist workflow (which appears to be picking up 3.13) to pass.

Fixes: #9110

Blocked by regtest failures: https://github.com/spacetelescope/RegressionTests/actions/runs/13037094545

This is also block by a TBD PR dropping 3.10 support since stcal main no longer support 3.10.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.datamodels.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.fits_generator.rst
  • changes/<PR#>.set_telescope_pointing.rst
  • changes/<PR#>.pipeline.rst

stage 1

  • changes/<PR#>.group_scale.rst
  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.emicorr.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.ipc.rst
  • changes/<PR#>.firstframe.rst
  • changes/<PR#>.lastframe.rst
  • changes/<PR#>.reset.rst
  • changes/<PR#>.superbias.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.rscd.rst
  • changes/<PR#>.persistence.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.charge_migration.rst
  • changes/<PR#>.jump.rst
  • changes/<PR#>.clean_flicker_noise.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.gain_scale.rst

stage 2

  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.badpix_selfcal.rst
  • changes/<PR#>.msaflagopen.rst
  • changes/<PR#>.nsclean.rst
  • changes/<PR#>.imprint.rst
  • changes/<PR#>.background.rst
  • changes/<PR#>.extract_2d.rst
  • changes/<PR#>.master_background.rst
  • changes/<PR#>.wavecorr.rst
  • changes/<PR#>.srctype.rst
  • changes/<PR#>.straylight.rst
  • changes/<PR#>.wfss_contam.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.fringe.rst
  • changes/<PR#>.pathloss.rst
  • changes/<PR#>.barshadow.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.pixel_replace.rst
  • changes/<PR#>.resample_spec.rst
  • changes/<PR#>.residual_fringe.rst
  • changes/<PR#>.cube_build.rst
  • changes/<PR#>.extract_1d.rst
  • changes/<PR#>.resample.rst

stage 3

  • changes/<PR#>.assign_mtwcs.rst
  • changes/<PR#>.mrs_imatch.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.exp_to_source.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.tso_photometry.rst
  • changes/<PR#>.stack_refs.rst
  • changes/<PR#>.align_refs.rst
  • changes/<PR#>.klip.rst
  • changes/<PR#>.spectral_leak.rst
  • changes/<PR#>.source_catalog.rst
  • changes/<PR#>.combine_1d.rst
  • changes/<PR#>.ami.rst

other

  • changes/<PR#>.wfs_combine.rst
  • changes/<PR#>.white_light.rst
  • changes/<PR#>.cube_skymatch.rst
  • changes/<PR#>.engdb_tools.rst
  • changes/<PR#>.guider_cds.rst

@braingram braingram closed this Jan 29, 2025
@braingram braingram changed the title set stcal to main set stcal to main, allow python 3.13 Jan 29, 2025
@braingram braingram reopened this Jan 29, 2025
@github-actions github-actions bot added assign_wcs testing automation Continuous Integration (CI) and testing automation tools labels Jan 29, 2025
@tapastro
Copy link
Contributor

I just started regtests on this old PR: #8864

Should I kill that off and start one with this?

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (bd46fad) to head (260e63a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9105   +/-   ##
=======================================
  Coverage   78.15%   78.15%           
=======================================
  Files         505      505           
  Lines       46244    46244           
=======================================
  Hits        36141    36141           
  Misses      10103    10103           
Flag Coverage Δ *Carryforward flag
nightly 77.77% <ø> (ø) Carriedforward from bd46fad

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram
Copy link
Collaborator Author

I just started regtests on this old PR: #8864

Should I kill that off and start one with this?

Thanks for checking. I'd say leave them running. I expect failures which would be reason to not rush allowing 3.13.

@tapastro
Copy link
Contributor

Perhaps worth adding an upper pin on 3.14 until we can test with it, once it exists? Opened #9110 to track reversion of #9106 - not sure if I did that in the proper git-wizard method but did my best.

@tapastro
Copy link
Contributor

Would it be overloading the PR to also drop python 3.10 support here?

@braingram
Copy link
Collaborator Author

Would it be overloading the PR to also drop python 3.10 support here?

I'd say yes. Is there anything preventing dropping python 3.10? The python 3.13 bump requires further regtest investigation right?

Perhaps worth adding an upper pin on 3.14 until we can test with it, once it exists? Opened #9110 to track reversion of #9106 - not sure if I did that in the proper git-wizard method but did my best.

Good idea on the upper pin! I'll add that to this PR.

@braingram braingram force-pushed the fix_build branch 2 times, most recently from b3a6009 to 743910f Compare January 29, 2025 22:19
@tapastro
Copy link
Contributor

The test set run on the closed PR ( https://github.com/spacetelescope/RegressionTests/actions/runs/13037094545 ) were fairly promising - perhaps worth investigating a possible change in numerical behavior for WFSS background subtraction, but the bulk differences look fairly innocuous to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assign_wcs automation Continuous Integration (CI) and testing automation tools installation testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert change to build workflow to accommodate python upper pin
2 participants