Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug that raised traceback when creating subsets #26

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jun 6, 2023

introduced by mouseover coordinates trying to access viewer.data()[0].flux.unit

* introduced by mouseover coordinates trying to access viewer.data()[0].flux.unit
@kecnry kecnry requested a review from bmorris3 June 6, 2023 14:26
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.13 ⚠️

Comparison is base (8077908) 85.76% compared to head (80bce3a) 85.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   85.76%   85.64%   -0.13%     
==========================================
  Files          19       19              
  Lines         794      794              
==========================================
- Hits          681      680       -1     
- Misses        113      114       +1     
Impacted Files Coverage Δ
lcviz/utils.py 85.85% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (and apologies I hadn't foreseen this).

@kecnry kecnry merged commit aeadc9a into spacetelescope:main Jun 6, 2023
@kecnry kecnry deleted the fix-subset-bug branch June 6, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants