Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data model constructors should return object instance used in constructor if right type #51

Closed
perrygreenfield opened this issue Nov 4, 2021 · 1 comment
Closed

Data model constructors should return object instance used in constructor if right type #51

perrygreenfield opened this issue Nov 4, 2021 · 1 comment
Assignees
@perrygreenfield

Comments

@perrygreenfield
Copy link
Collaborator

Currently if one supplies an existing instance of a datamodel (say RampModel) to one of the datamodel constructors (say RampModel), and the instance is the same type as the constructor, the constructor should return that instance. Currently it raises an error.

This may require some trickery to effectively replace self with the instance (I will have to brush up on this)
@perrygreenfield perrygreenfield mentioned this issue Nov 9, 2021
Merged
@nden
Copy link
Collaborator

nden commented Nov 19, 2021

Fixed in #52

@nden nden closed this as completed Nov 19, 2021
dmggh added a commit to dmggh/roman_datamodels that referenced this issue Dec 16, 2021
@dmggh
Merge pull request spacetelescope#51 from nden/docs-badge
c80cc31 
add Readthedocs badge to README
WilliamJamieson added a commit to WilliamJamieson/roman_datamodels that referenced this issue Jul 6, 2023
@WilliamJamieson
Implement passing the exact object through a datamodel constructor.
c5c6320 
Issue spacetelescope#51 and PR spacetelescope#52 indicate that we should be able to pass a
model instance to a matching model's constructor, and then
return exactly the same instance unmodified.
@WilliamJamieson WilliamJamieson mentioned this issue Jul 6, 2023
Merged
4 tasks
WilliamJamieson added a commit to WilliamJamieson/roman_datamodels that referenced this issue Jul 7, 2023
@WilliamJamieson
Implement passing the exact object through a datamodel constructor.
6e69967 
Issue spacetelescope#51 and PR spacetelescope#52 indicate that we should be able to pass a
model instance to a matching model's constructor, and then
return exactly the same instance unmodified.
WilliamJamieson added a commit to WilliamJamieson/roman_datamodels that referenced this issue Jul 7, 2023
@WilliamJamieson
Implement passing the exact object through a datamodel constructor.
c6650f5 
Issue spacetelescope#51 and PR spacetelescope#52 indicate that we should be able to pass a
model instance to a matching model's constructor, and then
return exactly the same instance unmodified.
WilliamJamieson added a commit to WilliamJamieson/roman_datamodels that referenced this issue Jul 7, 2023
@WilliamJamieson
Implement passing the exact object through a datamodel constructor.
a4fb5dc 
Issue spacetelescope#51 and PR spacetelescope#52 indicate that we should be able to pass a
model instance to a matching model's constructor, and then
return exactly the same instance unmodified.
WilliamJamieson added a commit to WilliamJamieson/roman_datamodels that referenced this issue Jul 7, 2023
@WilliamJamieson
Implement passing the exact object through a datamodel constructor.
04ea7b6 
Issue spacetelescope#51 and PR spacetelescope#52 indicate that we should be able to pass a
model instance to a matching model's constructor, and then
return exactly the same instance unmodified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@perrygreenfield perrygreenfield

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@perrygreenfield @nden