Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the random_utils #217

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Jun 22, 2023

Closes #215 and closes #216

This PR removes all randomness from the maker_utils and then removes the random_utls as they are no-longer needed.

Checklist

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@d374fe9). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head f7aa03c differs from pull request most recent head 0a3f74d. Consider uploading reports for the commit 0a3f74d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage        ?   94.47%           
=======================================
  Files           ?       23           
  Lines           ?     1628           
  Branches        ?        0           
=======================================
  Hits            ?     1538           
  Misses          ?       90           
  Partials        ?        0           
Impacted Files Coverage Δ
src/roman_datamodels/maker_utils/_common_meta.py 100.00% <100.00%> (ø)
src/roman_datamodels/maker_utils/_datamodels.py 96.57% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WilliamJamieson WilliamJamieson requested a review from PaulHuwe June 22, 2023 13:54
@WilliamJamieson WilliamJamieson marked this pull request as ready for review June 22, 2023 13:54
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner June 22, 2023 13:54
@WilliamJamieson WilliamJamieson force-pushed the refactor/drop_random_utils branch 5 times, most recently from 31a9a5e to 02562fd Compare June 23, 2023 18:09
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson force-pushed the refactor/drop_random_utils branch from 02562fd to f7aa03c Compare June 27, 2023 17:43
@WilliamJamieson WilliamJamieson force-pushed the refactor/drop_random_utils branch from f7aa03c to 0a3f74d Compare June 27, 2023 17:46
@WilliamJamieson WilliamJamieson enabled auto-merge (squash) June 27, 2023 17:47
@WilliamJamieson WilliamJamieson merged commit d94a4d6 into spacetelescope:main Jun 27, 2023
@WilliamJamieson WilliamJamieson deleted the refactor/drop_random_utils branch June 27, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we drop the random_utils module? Should we remove randomness from the maker_utils?
2 participants