-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maker_utils so that saved nodes are still returned #218
Update maker_utils so that saved nodes are still returned #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note: I never completed the jira issue filing. So, nevermind on that.
5afb10c
to
d0bcb08
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 94.47% 94.17% -0.30%
==========================================
Files 23 23
Lines 1628 1545 -83
==========================================
- Hits 1538 1455 -83
Misses 90 90
☔ View full report in Codecov by Sentry. |
f9bb814
to
eae5708
Compare
eae5708
to
2a40e72
Compare
2a40e72
to
2b597fa
Compare
3f5c1d0
to
674c30c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM sweep sweep sweep
@stscieisenhamer requested that the
maker_utils
return the nodes even when they are saving the node to ASDF. This will not effect any current uses as the output will be thrown away, but it will enable one to use the node made by the maker_util and saved to a file without having to open that file.Checklist
CHANGES.rst
under the corresponding subsection