Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maker utils to use correct units #256

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

This PR properly resolves the units required by spacetelescope/rad#300 which resolves some inconsistencies between the two libraries.

Checklist

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fdabf82) 96.68% compared to head (c80075e) 96.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          29       29           
  Lines        2413     2413           
=======================================
  Hits         2333     2333           
  Misses         80       80           
Files Changed Coverage Δ
src/roman_datamodels/maker_utils/_tagged_nodes.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamJamieson WilliamJamieson marked this pull request as ready for review August 3, 2023 17:44
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner August 3, 2023 17:44
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit 1a785ee into spacetelescope:main Aug 3, 2023
@WilliamJamieson WilliamJamieson deleted the bugfix/missing_units branch August 3, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants