Bump min versions #258
Merged
Bump min versions #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
+ Coverage 96.56% 96.67% +0.11%
==========================================
Files 29 28 -1
Lines 2413 2406 -7
==========================================
- Hits 2330 2326 -4
+ Misses 83 80 -3 ☔ View full report in Codecov by Sentry. |
|
This looks reasonable. 5.0.x is super old by now and getting dropped at the end of 2023. |
nden
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oldest versions pins for
roman_datamodelsare currently broken. This is due to a breaking change in unit representations introduced in astropy/astropy#14439, which first appeared in astropy 5.3.0. So the min astropy version has been bumped to 5.3.0.This necessitated an additional bump in numpy version at least 1.21. However, numpy 1.22 is the oldest supported version by numpy, so it makes sense to bump to 1.22.
Checklist
CHANGES.rstunder the corresponding subsection[ ] Passed romancal regression testing on Jenkins / PLWishMaster. Link: https://plwishmaster.stsci.edu:8081/job/RT/job/romancal/XXX/The regression tests use the latest versions of these dependencies on PyPi not the minimum versions. However, this may require version bumps inromancalfor the oldest dependencies job to remain functional.