Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added truncation to exposure. #283

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Added truncation to exposure. #283

merged 3 commits into from
Oct 20, 2023

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented Oct 14, 2023 •
edited
Loading

Resolves RCAL-689

Closes #927

This PR adds the truncated keyword to the exposure group.

Checklist

@codecov
Copy link

codecov bot commented Oct 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/roman_datamodels/maker_utils/_common_meta.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@stscijgbot-rstdms stscijgbot-rstdms mentioned this pull request Oct 14, 2023
Closed
@PaulHuwe PaulHuwe marked this pull request as ready for review October 19, 2023 18:49
@PaulHuwe PaulHuwe requested review from WilliamJamieson and a team as code owners October 19, 2023 18:49
schlafly
schlafly approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@PaulHuwe PaulHuwe merged commit 33368d1 into spacetelescope:main Oct 20, 2023
14 checks passed
@PaulHuwe PaulHuwe deleted the RCAL-689_Truncation branch October 20, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlafly schlafly schlafly approved these changes

@WilliamJamieson WilliamJamieson Awaiting requested review from WilliamJamieson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulHuwe @schlafly