Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make model subscription follow the same reasoning as node subscription #322

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Feb 20, 2024

Datamodels are currently not subscribable and setting through subscription acts differently than it does for nodes. This is surprising behavior. This PR brings subscription for datamodels in line with the expectations for node objects.

Checklist

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.58%. Comparing base (087a60d) to head (6aab3f0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   97.56%   97.58%   +0.02%     
==========================================
  Files          30       31       +1     
  Lines        2788     2814      +26     
==========================================
+ Hits         2720     2746      +26     
  Misses         68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schlafly
Copy link
Collaborator

@WilliamJamieson is out. Can one of you run the regtests and then merge? Thanks!

@PaulHuwe
Copy link
Collaborator

I am on it. regtests passed and linked. Will merge after unit tests pass.

@PaulHuwe PaulHuwe merged commit 8dcb8dc into spacetelescope:main Feb 26, 2024
15 of 16 checks passed
@WilliamJamieson WilliamJamieson deleted the feature/subscribable branch February 28, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants