Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused sphinx-asdf #326

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

braingram
Copy link
Collaborator

sphinx-asdf is listed as a required dependency for docs. It is unused by the documentation (it handles rendering schemas so is useful for RAD but not roman_datamodels).

This PR removes sphinx-asdf as a dependency.

Checklist

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (087a60d) to head (ec687b6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   97.56%   97.57%   +0.01%     
==========================================
  Files          30       31       +1     
  Lines        2788     2808      +20     
==========================================
+ Hits         2720     2740      +20     
  Misses         68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review February 26, 2024 16:21
@braingram braingram requested a review from a team as a code owner February 26, 2024 16:21
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram braingram merged commit 038abc0 into spacetelescope:main Feb 26, 2024
16 of 17 checks passed
@braingram braingram deleted the remove_sphinx_asdf branch February 26, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants