Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-804: Split cal_step into L2 & L3 #334

Merged
merged 8 commits into from
Mar 29, 2024

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented Mar 27, 2024

Resolves RCAL-804

Closes #

This PR splits the cal_step datamodels into L2 and L3 versions.

Checklist

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (087a60d) to head (b54fe35).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   97.56%   97.33%   -0.23%     
==========================================
  Files          30       31       +1     
  Lines        2788     2965     +177     
==========================================
+ Hits         2720     2886     +166     
- Misses         68       79      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe
Copy link
Collaborator Author

NOTE: these changes require updates to romancal regression test files as shown in the Jenkins URL.

@PaulHuwe PaulHuwe marked this pull request as ready for review March 27, 2024 15:51
@PaulHuwe PaulHuwe requested a review from a team as a code owner March 27, 2024 15:51
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nden
Copy link
Collaborator

nden commented Mar 29, 2024

The latest changes in RAD are related to this PR. Since merging this will point roman_datamodels back to rad/main I'm going to go ahead and merge it so I can get romancal installable again.

@nden nden merged commit 34296a8 into spacetelescope:main Mar 29, 2024
15 of 16 checks passed
@nden nden added this to the 24Q3_B14 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants