Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linting issue with type comparison #356

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

zacharyburnett
Copy link
Collaborator

blocks #354

Checklist

@zacharyburnett zacharyburnett self-assigned this Jul 3, 2024
@zacharyburnett zacharyburnett requested a review from a team as a code owner July 3, 2024 18:08
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (087a60d) to head (cbed49a).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   97.56%   97.55%   -0.01%     
==========================================
  Files          30       36       +6     
  Lines        2788     3349     +561     
==========================================
+ Hits         2720     3267     +547     
- Misses         68       82      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharyburnett zacharyburnett merged commit 98d9084 into spacetelescope:main Jul 3, 2024
14 of 17 checks passed
@zacharyburnett zacharyburnett deleted the fix/linting branch July 3, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants