Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unreachable code due to new asdf version requirement #365

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

braingram
Copy link
Collaborator

Closes #364

This PR removes code that is now unreachable since the minimum asdf version is >3.dev.

Checklist

@braingram braingram requested a review from a team as a code owner July 30, 2024 14:44
@braingram braingram changed the title remove unused code remove unreachable code due to new asdf version requirement Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (087a60d) to head (4e81378).
Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   97.56%   97.66%   +0.09%     
==========================================
  Files          30       37       +7     
  Lines        2788     3334     +546     
==========================================
+ Hits         2720     3256     +536     
- Misses         68       78      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram requested a review from zacharyburnett July 30, 2024 23:55
@braingram braingram merged commit 37af770 into spacetelescope:main Jul 31, 2024
16 of 17 checks passed
@braingram braingram deleted the asdf_version_check branch July 31, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove check for asdf version older than lower pin
2 participants