Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata for release 0.21.0 #374

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

zacharyburnett
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (087a60d) to head (ef8089c).
Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   97.56%   97.68%   +0.12%     
==========================================
  Files          30       37       +7     
  Lines        2788     3365     +577     
==========================================
+ Hits         2720     3287     +567     
- Misses         68       78      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you will re-run the tests once the RAD release is done?

@zacharyburnett
Copy link
Collaborator Author

did mk_sky_background get deprecated?
https://github.com/spacetelescope/roman_datamodels/actions/runs/10268044787/job/28411458330#step:10:343

=========================== short test summary info ============================
FAILED tests/test_maker_utils.py::test_maker_utility_implemented[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
FAILED tests/test_maker_utils.py::test_instance_valid[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
FAILED tests/test_maker_utils.py::test_no_extra_fields[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
FAILED tests/test_stnode.py::test_copy[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
FAILED tests/test_stnode.py::test_serialization[SkyBackground] - ValueError: Maker utility: mk_sky_background not implemented for class SkyBackground
================== 5 failed, 2102 passed in 82.00s (0:01:22) ===================

@PaulHuwe
Copy link
Collaborator

PaulHuwe commented Aug 6, 2024

No, that was just added.

@PaulHuwe
Copy link
Collaborator

PaulHuwe commented Aug 6, 2024

I see the issue.. resolving now.

@PaulHuwe
Copy link
Collaborator

PaulHuwe commented Aug 6, 2024

I merged a PR, rerunning the tests.

@zacharyburnett
Copy link
Collaborator Author

looks like that fixed it!

@zacharyburnett zacharyburnett merged commit 5e996c3 into spacetelescope:main Aug 6, 2024
16 checks passed
@zacharyburnett zacharyburnett deleted the release_metadata branch August 6, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants