Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mk_level2_image for 3d shape #378

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Aug 15, 2024

I initially hoped to drop the 3d shape input. However the maker_utils tests are quite tied to the current structure and it wasn't immediately obvious how to drop the 3d input without breaking several other tests (which provide a 3d shape).

Instead this PR takes the approach of fixing the 3d shape input handling and adds a regression test for the issue.

Closes #377

Regression tests running at https://github.com/spacetelescope/RegressionTests/actions/runs/10405495032

Checklist

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (087a60d) to head (80c2f6e).
Report is 69 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   97.56%   97.68%   +0.12%     
==========================================
  Files          30       37       +7     
  Lines        2788     3370     +582     
==========================================
+ Hits         2720     3292     +572     
- Misses         68       78      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review August 15, 2024 14:29
@braingram braingram requested a review from a team as a code owner August 15, 2024 14:29
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Brett!

@braingram braingram merged commit 6597e76 into spacetelescope:main Aug 15, 2024
16 checks passed
@braingram braingram deleted the mk_level2_shape branch August 15, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shape argument to mk_level2_image doesn't work as described
2 participants