use shorter string for NOSTR value #388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
NOSTR
value used in the maker utils is incompatible with some archive_catalog nvarchar entries. Although this value likely shouldn't ever end up in the archive it prevents adding correspondingminLength
keywords to the schemas (to check these nvarchars during schema validation).This PR set's a new
NOSTR
value of?
. This was chosen as the smallestnvarchar
value is 2 for visit_file_activity.meta.filename
requires a different valuenone
assource_catalog
will use this value for some unit tests:https://github.com/spacetelescope/romancal/blob/96af8bbc6a6dafd48d1beb251b5209d9da875ca1/romancal/source_catalog/source_catalog_step.py#L151
Which then leads to a failure since it attempts to write to "?".
romancal also includes some of these default values in the doctests. spacetelescope/romancal#1419 is needed before this PR can be merged. EDIT: romancal PR is merged, rerunning regtests but will open this for review in case there are requested changes
Regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/10966346784
show same failures as main: https://github.com/spacetelescope/RegressionTests/actions/runs/10998102193
This PR is a requirement for spacetelescope/rad#448
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)romancal
regression test with this branch installed ("git+https://github.com/<fork>/roman_datamodels@<branch>"
)news fragment change types...
changes/<PR#>.feature.rst
: new featurechanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.removal.rst
: deprecation or removal of public APIchanges/<PR#>.misc.rst
: infrastructure or miscellaneous change