Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable dependabot for github actions workflows #395

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

braingram
Copy link
Collaborator

Enable dependabot to check for updates to and open PRs to update github actions workflow files.

I think we should do this before (or in concert with) #392 as the exact pins mean we won't see security/bugfix/feature updates to actions unless the pins are updated (which dependabot will help us do).

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • start a romancal regression test with this branch installed ("git+https://github.com/<fork>/roman_datamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (087a60d) to head (cb3f42b).
Report is 88 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   97.56%   97.75%   +0.19%     
==========================================
  Files          30       37       +7     
  Lines        2788     3380     +592     
==========================================
+ Hits         2720     3304     +584     
- Misses         68       76       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we also tell it to tag reviewers?

schedule:
interval: "monthly"
reviewers:
- "zacharyburnett"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zacharyburnett just to confirm. You wanted me to add this right? I don't want to sneak this in post-approval if not.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes indeed, please!

@zacharyburnett zacharyburnett merged commit 0c6640f into spacetelescope:main Oct 1, 2024
18 checks passed
@braingram braingram deleted the dependabot branch October 1, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants