-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-927: Add ref_file entry for reference pixel subtraction reference file #397
RCAL-927: Add ref_file entry for reference pixel subtraction reference file #397
Conversation
…dels into RCAL-927_RefPixRefFile
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
==========================================
+ Coverage 97.56% 97.77% +0.21%
==========================================
Files 30 36 +6
Lines 2788 3461 +673
==========================================
+ Hits 2720 3384 +664
- Misses 68 77 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
Regression tests show only the expected failures from the new refpix
:
{'dictionary_item_added': ["root['roman']['meta']['ref_file']['refpix']"]}
Waiting to approve until spacetelescope/rad#458 is merged and the rad requirement updated to main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the RAD pin.
Resolves RCAL-927
Closes #
This PR adds ref_file entry for reference pixel subtraction reference file.
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)romancal
regression test with this branch installed ("git+https://github.com/<fork>/roman_datamodels@<branch>"
)news fragment change types...
changes/<PR#>.feature.rst
: new featurechanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.removal.rst
: deprecation or removal of public APIchanges/<PR#>.misc.rst
: infrastructure or miscellaneous change