Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-927: Add ref_file entry for reference pixel subtraction reference file #397

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented Oct 3, 2024

Resolves RCAL-927

Closes #

This PR adds ref_file entry for reference pixel subtraction reference file.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • start a romancal regression test with this branch installed ("git+https://github.com/<fork>/roman_datamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (087a60d) to head (0a679d9).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   97.56%   97.77%   +0.21%     
==========================================
  Files          30       36       +6     
  Lines        2788     3461     +673     
==========================================
+ Hits         2720     3384     +664     
- Misses         68       77       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe
Copy link
Collaborator Author

PaulHuwe commented Oct 7, 2024

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

Regression tests show only the expected failures from the new refpix:

   {'dictionary_item_added': ["root['roman']['meta']['ref_file']['refpix']"]}

Waiting to approve until spacetelescope/rad#458 is merged and the rad requirement updated to main.

pyproject.toml Outdated Show resolved Hide resolved
@PaulHuwe PaulHuwe self-assigned this Oct 11, 2024
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the RAD pin.

@PaulHuwe PaulHuwe merged commit 065b958 into spacetelescope:main Oct 11, 2024
18 checks passed
@PaulHuwe PaulHuwe deleted the RCAL-927_RefPixRefFile branch October 11, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants