-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-911 & 932: remove units from MOS and ELP pipelines. #405
Merged
PaulHuwe
merged 9 commits into
spacetelescope:main
from
mairanteodoro:RCAL-932-remove-units-in-exposure-level-pipeline
Oct 17, 2024
Merged
RCAL-911 & 932: remove units from MOS and ELP pipelines. #405
PaulHuwe
merged 9 commits into
spacetelescope:main
from
mairanteodoro:RCAL-932-remove-units-in-exposure-level-pipeline
Oct 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 97.56% 97.77% +0.21%
==========================================
Files 30 37 +7
Lines 2788 3456 +668
==========================================
+ Hits 2720 3379 +659
- Misses 68 77 +9 ☔ View full report in Codecov by Sentry. |
This all looks good to me, thanks! |
This was referenced Oct 16, 2024
PaulHuwe
reviewed
Oct 17, 2024
PaulHuwe
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-911
Resolves RCAL-932
This PR modifies several files so that units are not used anymore. Additionally, the filename used in the regression tests was changed to remove the
ggsaa
component.The information about units is still retained in the RAD schema.
Tasks
24Q4_B15
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth filesnews fragment change types...
changes/405.general.rst
: Remove units from roman_datamodels.