Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-911 & 932: remove units from MOS and ELP pipelines. #405

Conversation

mairanteodoro
Copy link
Collaborator

@mairanteodoro mairanteodoro commented Oct 16, 2024

Resolves RCAL-911
Resolves RCAL-932

This PR modifies several files so that units are not used anymore. Additionally, the filename used in the regression tests was changed to remove the ggsaa component.

The information about units is still retained in the RAD schema.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/405.general.rst: Remove units from roman_datamodels.

@mairanteodoro mairanteodoro marked this pull request as ready for review October 16, 2024 18:55
@mairanteodoro mairanteodoro requested a review from a team as a code owner October 16, 2024 18:55
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (087a60d) to head (6cfe09a).
Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   97.56%   97.77%   +0.21%     
==========================================
  Files          30       37       +7     
  Lines        2788     3456     +668     
==========================================
+ Hits         2720     3379     +659     
- Misses         68       77       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly
Copy link
Collaborator

This all looks good to me, thanks!

pyproject.toml Outdated Show resolved Hide resolved
@PaulHuwe PaulHuwe enabled auto-merge (squash) October 17, 2024 14:26
@PaulHuwe PaulHuwe disabled auto-merge October 17, 2024 14:26
@PaulHuwe PaulHuwe merged commit a4542f1 into spacetelescope:main Oct 17, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants