Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove units from guidewindow #415

Conversation

WilliamJamieson
Copy link
Collaborator

This PR updates roman_datamodels to support spacetelescope/rad#499.

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner November 4, 2024 19:15
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.41%. Comparing base (087a60d) to head (0d54c71).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   97.56%   97.41%   -0.15%     
==========================================
  Files          30       37       +7     
  Lines        2788     3449     +661     
==========================================
+ Hits         2720     3360     +640     
- Misses         68       89      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDP is fine with this going in now. @ddavis-stsci may end up needing to make some new guide window files, but he says that that will be straightforward if needed. Looks good to me, thanks!

@WilliamJamieson WilliamJamieson force-pushed the feature/remove_guidewindow_units branch from 31e2fc5 to 0d54c71 Compare November 5, 2024 21:16
@WilliamJamieson WilliamJamieson merged commit 3ed89f4 into spacetelescope:main Nov 5, 2024
17 of 18 checks passed
@WilliamJamieson WilliamJamieson deleted the feature/remove_guidewindow_units branch November 5, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants