Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rcal 910 Add target option to the asn_from_list command #1411

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

ddavis-stsci
Copy link
Collaborator

@ddavis-stsci ddavis-stsci commented Sep 17, 2024

Resolves RCAL-910

Closes #1408

This PR adds the target option to the asn_from_list command, updates the documentation.
The command
asn_from_list --target s154 --product-name l3_mosaic_target r0000101001001001001_01101_000?_WFI01_cal.asdf -o l3_target_asn.json

now adds the target to the asn file.

Checklist

  • for a public change, added a towncrier news fragment in changes/

    echo "changed something" > changes/<PR#>.<changetype>.rst

    • changes/<PR#>.general.rst: infrastructure or miscellaneous change
    • changes/<PR#>.docs.rst
    • changes/<PR#>.stpipe.rst
    • changes/<PR#>.associations.rst
    • changes/<PR#>.scripts.rst
    • changes/<PR#>.mosaic_pipeline.rst
    • changes/<PR#>.patch_match.rst

    steps

    • changes/<PR#>.dq_init.rst
    • changes/<PR#>.saturation.rst
    • changes/<PR#>.refpix.rst
    • changes/<PR#>.linearity.rst
    • changes/<PR#>.dark_current.rst
    • changes/<PR#>.jump_detection.rst
    • changes/<PR#>.ramp_fitting.rst
    • changes/<PR#>.assign_wcs.rst
    • changes/<PR#>.flatfield.rst
    • changes/<PR#>.photom.rst
    • changes/<PR#>.flux.rst
    • changes/<PR#>.source_detection.rst
    • changes/<PR#>.tweakreg.rst
    • changes/<PR#>.skymatch.rst
    • changes/<PR#>.outlier_detection.rst
    • changes/<PR#>.resample.rst
    • changes/<PR#>.source_catalog.rst
  • updated relevant tests

  • updated relevant documentation

  • updated relevant milestone(s)

  • added relevant label(s)

  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR
    The passing regression tests are at
    https://github.com/spacetelescope/RegressionTests/actions/runs/10903622177

@ddavis-stsci ddavis-stsci added this to the 25Q1_B16 milestone Sep 17, 2024
@ddavis-stsci ddavis-stsci self-assigned this Sep 17, 2024
@ddavis-stsci ddavis-stsci requested a review from a team as a code owner September 17, 2024 13:46
@github-actions github-actions bot added documentation Improvements or additions to documentation testing labels Sep 17, 2024
CHANGES.rst Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.52%. Comparing base (93f1cec) to head (016db76).
Report is 273 commits behind head on main.

Files with missing lines Patch % Lines
romancal/associations/lib/rules_elpp_base.py 16.66% 5 Missing ⚠️
romancal/associations/association.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1411      +/-   ##
==========================================
- Coverage   78.52%   78.52%   -0.01%     
==========================================
  Files         117      117              
  Lines        7833     7842       +9     
==========================================
+ Hits         6151     6158       +7     
- Misses       1682     1684       +2     
Flag Coverage Δ *Carryforward flag
nightly 62.29% <ø> (+0.04%) ⬆️ Carriedforward from 6e9ec5c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ddavis-stsci ddavis-stsci merged commit 96af8bb into spacetelescope:main Sep 17, 2024
30 of 31 checks passed
@ddavis-stsci ddavis-stsci deleted the rcal-910_dsd branch September 17, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
associations documentation Improvements or additions to documentation testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update asn_from_list to accept target argument
3 participants