Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeowners and remove unused files #1577

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jan 9, 2025

This PR removes the unused:

  • JenkinsfileRT
  • JenkinsfileRT_dev
  • CODEOWNERS.txt

and updates the used .github/CODEOWNERS file matching changes in spacetelescope/jwst#9055

The change in ownership should allow this repo to enable Require review from Code Owners in the branch protection rules. PRs that change files outside of the select few defined in the .github/CODEOWNERS file will require approval by a romancal-maintainer before merging. Note that this will not prevent a so approved PR from being merged by a romancal-developer.

The romancal-developers team current contains me and the romancal-maintainers and should have it's membership filled out.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.patch_match.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

@braingram braingram marked this pull request as ready for review January 10, 2025 16:09
@braingram braingram requested a review from a team as a code owner January 10, 2025 16:09
@braingram
Copy link
Collaborator Author

@schlafly @ddavis-stsci This PR includes the corresponding romancal changes to align the workflow with jwst following spacetelescope/jwst#9055

Once this PR is merged the branch protections can be updated. However I do not have the permission to do so. Do either of you?

Finally, is there a list of folks that you'd like me to invite to the romancal-developers team? Once the invites are sent or if you'd like to send them I'll remove myself as a maintainer of that team.

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddavis-stsci
Copy link
Collaborator

I should have permissions to make these changes. Do you know off hand what the setting is? If not I can look it up or check the JWST setup.

@schlafly @ddavis-stsci This PR includes the corresponding romancal changes to align the workflow with jwst following spacetelescope/jwst#9055

Once this PR is merged the branch protections can be updated. However I do not have the permission to do so. Do either of you?

Finally, is there a list of folks that you'd like me to invite to the romancal-developers team? Once the invites are sent or if you'd like to send them I'll remove myself as a maintainer of that team.

@braingram
Copy link
Collaborator Author

I should have permissions to make these changes. Do you know off hand what the setting is? If not I can look it up or check the JWST setup.

@schlafly @ddavis-stsci This PR includes the corresponding romancal changes to align the workflow with jwst following spacetelescope/jwst#9055
Once this PR is merged the branch protections can be updated. However I do not have the permission to do so. Do either of you?
Finally, is there a list of folks that you'd like me to invite to the romancal-developers team? Once the invites are sent or if you'd like to send them I'll remove myself as a maintainer of that team.

Thanks!

For modifying the branch protections those are:

Screenshot 2025-01-10 at 1 09 42 PM
  • on the right you'll see a column for main, click Edit
Screenshot 2025-01-10 at 1 09 02 PM
  • then enable the setting Require review from Code Owners
Screenshot 2025-01-10 at 1 08 09 PM

For adding members to romancal-developers visit the team page, click the green Add a member button and search/input the user name to add.

@schlafly
Copy link
Collaborator

Thanks. I added everyone with a recent romancal commit to romancal-developers team.

@ddavis-stsci
Copy link
Collaborator

ddavis-stsci commented Jan 10, 2025 via email

@braingram
Copy link
Collaborator Author

Thanks. I added everyone with a recent romancal commit to romancal-developers team.

Thanks! I removed myself as a maintainer of that list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants