-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codeowners and remove unused files #1577
base: main
Are you sure you want to change the base?
Conversation
@schlafly @ddavis-stsci This PR includes the corresponding romancal changes to align the workflow with jwst following spacetelescope/jwst#9055 Once this PR is merged the branch protections can be updated. However I do not have the permission to do so. Do either of you? Finally, is there a list of folks that you'd like me to invite to the romancal-developers team? Once the invites are sent or if you'd like to send them I'll remove myself as a maintainer of that team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I should have permissions to make these changes. Do you know off hand what the setting is? If not I can look it up or check the JWST setup.
|
Thanks! For modifying the branch protections those are:
For adding members to romancal-developers visit the team page, click the green |
Thanks. I added everyone with a recent romancal commit to romancal-developers team. |
Thanks! I removed myself as a maintainer of that list. |
This PR removes the unused:
and updates the used .github/CODEOWNERS file matching changes in spacetelescope/jwst#9055
The change in ownership should allow this repo to enable
Require review from Code Owners
in the branch protection rules. PRs that change files outside of the select few defined in the .github/CODEOWNERS file will require approval by a romancal-maintainer before merging. Note that this will not prevent a so approved PR from being merged by a romancal-developer.The
romancal-developers
team current contains me and theromancal-maintainers
and should have it's membership filled out.Tasks
24Q4_B15
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth filesnews fragment change types...
changes/<PR#>.general.rst
: infrastructure or miscellaneous changechanges/<PR#>.docs.rst
changes/<PR#>.stpipe.rst
changes/<PR#>.associations.rst
changes/<PR#>.scripts.rst
changes/<PR#>.mosaic_pipeline.rst
changes/<PR#>.patch_match.rst
steps
changes/<PR#>.dq_init.rst
changes/<PR#>.saturation.rst
changes/<PR#>.refpix.rst
changes/<PR#>.linearity.rst
changes/<PR#>.dark_current.rst
changes/<PR#>.jump_detection.rst
changes/<PR#>.ramp_fitting.rst
changes/<PR#>.assign_wcs.rst
changes/<PR#>.flatfield.rst
changes/<PR#>.photom.rst
changes/<PR#>.flux.rst
changes/<PR#>.source_detection.rst
changes/<PR#>.tweakreg.rst
changes/<PR#>.skymatch.rst
changes/<PR#>.outlier_detection.rst
changes/<PR#>.resample.rst
changes/<PR#>.source_catalog.rst