Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix devdeps #274

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix devdeps #274

merged 1 commit into from
Jul 26, 2024

Conversation

braingram
Copy link
Collaborator

The devdeps tests are failing due to a failure to find a tweakreg dependency:
https://github.com/spacetelescope/stcal/actions/runs/10099805963/job/27929757174

stcal/tox.ini

Line 65 in 5fbabf6

devdeps: tweakreg>=0.0.dev0

This PR fixes the typo to use tweakwcs and installs it from git (as I don't believe pre-releases are common for tweakwcs).

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@braingram braingram requested a review from a team as a code owner July 26, 2024 11:56
@braingram braingram requested review from emolter and zacharyburnett and removed request for a team July 26, 2024 11:56
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.01%. Comparing base (5772579) to head (58018d4).
Report is 196 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
+ Coverage   83.79%   84.01%   +0.22%     
==========================================
  Files          35       39       +4     
  Lines        6998     7345     +347     
==========================================
+ Hits         5864     6171     +307     
- Misses       1134     1174      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, sorry about that

@braingram braingram merged commit 2474152 into spacetelescope:main Jul 26, 2024
24 of 27 checks passed
@braingram braingram deleted the fix_devdeps branch July 26, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants