Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add weekly cron env to tox.ini to fix tox 4.9 compatibility #195

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

braingram
Copy link
Collaborator

See: spacetelescope/roman_datamodels#261 for more details

tox 4.9 will no longer run environments that are not either:

  • prefixed with a python version: e.g. py310 for python 3.10
  • listed in tox.ini

This PR adds the weekly cron env test-devdeps-xdist to tox.ini so hopefully it will fail in a new way succeed next week when run with tox 4.9.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@braingram braingram added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (345ae49) 64.01% compared to head (7281f5c) 64.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files         101      101           
  Lines        5558     5558           
=======================================
  Hits         3558     3558           
  Misses       2000     2000           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram
Copy link
Collaborator Author

The test failures appear unrelated to the changes in this PR.

Something appears up with test_crds_selectors_vs_datamodel[miri] perhaps a CRDS file was updated?

@braingram braingram marked this pull request as ready for review August 16, 2023 22:06
@braingram braingram requested a review from a team as a code owner August 16, 2023 22:06
@braingram
Copy link
Collaborator Author

test_crds_selectors_vs_datamodel[miri] failure (seen in several test runs) is unrelated and due to an update to a file on CRDS.

@zacharyburnett
Copy link
Collaborator

LGTM, when tests pass

@braingram
Copy link
Collaborator Author

LGTM, when tests pass

Thanks! All green after rebasing with changes from: #197

@braingram braingram merged commit e74ded1 into spacetelescope:master Aug 17, 2023
@braingram braingram deleted the fix_tox branch August 17, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Trivial change that doesn't need an entry in the change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants