Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search in docs by adding jquery to docs conf #241

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Dec 6, 2023

Applies the same fix as in: spacetelescope/jwst#7524

Fix search in docs by including jquery in the docs conf file.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12a4c3a) 64.71% compared to head (36a63b0) 64.75%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
+ Coverage   64.71%   64.75%   +0.03%     
==========================================
  Files         102      102              
  Lines        5668     5674       +6     
==========================================
+ Hits         3668     3674       +6     
  Misses       2000     2000              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review December 6, 2023 21:16
@braingram braingram requested a review from a team as a code owner December 6, 2023 21:16
@braingram braingram requested a review from tapastro December 6, 2023 21:17
@braingram braingram changed the title add jquery to docs conf Fix search in docs by adding jquery to docs conf Dec 6, 2023
Copy link
Collaborator

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@braingram braingram merged commit e1d435d into spacetelescope:master Dec 6, 2023
21 of 22 checks passed
@braingram braingram deleted the jquery branch December 6, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants