Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ifu docs to describe about coord_system and pixel scale #923

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented Oct 30, 2024

Improve docs to address some of the questions from that help desk ticket.

Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mperrin
Copy link
Collaborator Author

mperrin commented Oct 30, 2024

Huh. A few of the tests for this docs PR fail, in a way that’s completely unrelated to docs, which is the only thing that changed in this PR. Must be some kind of upstream change or dependency issue?? FYI @obi-wan76 @BradleySappington
Maybe one of you could investigate

@BradleySappington
Copy link
Collaborator

@mperrin, looks like photutils updated to version 2.0.2, last successful run it was 1.13.0

@BradleySappington
Copy link
Collaborator

@mperrin - I pushed updates to develop that I believe should fix this issue. If you would please merge develop into your update_ifu_docs repo, this pr should fall out and pass all tests. I also raised an issue for the cause of this failure that will need to be addressed separately.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.15%. Comparing base (490d6bf) to head (2dc5d45).
Report is 19 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #923   +/-   ##
========================================
  Coverage    62.15%   62.15%           
========================================
  Files           15       15           
  Lines         7016     7016           
========================================
  Hits          4361     4361           
  Misses        2655     2655           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@BradleySappington BradleySappington merged commit 629d73e into spacetelescope:develop Nov 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants