Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear Unmixing #1045

Merged
merged 10 commits into from
Mar 2, 2019
Merged

Conversation

ambrosejcarr
Copy link
Member

Based on #990

Opening a new PR so that @kevinyamauchi can take a look at the tests and make sure everything checks out without me force-pushing his branch.

@ambrosejcarr ambrosejcarr changed the title Ajc linear unmixing Linear Unmixing Feb 23, 2019
@codecov-io
Copy link

codecov-io commented Feb 23, 2019

Codecov Report

Merging #1045 into ajc-move-preserve-float-range will not change coverage.
The diff coverage is 92%.

Impacted file tree graph

@@                      Coverage Diff                       @@
##           ajc-move-preserve-float-range    #1045   +/-   ##
==============================================================
  Coverage                          88.48%   88.48%           
==============================================================
  Files                                164      164           
  Lines                               6139     6139           
==============================================================
  Hits                                5432     5432           
  Misses                               707      707
Impacted Files Coverage Δ
...tarfish/image/_filter/zero_by_channel_magnitude.py 100% <ø> (ø) ⬆️
starfish/spots/_detector/detect.py 98.36% <ø> (ø) ⬆️
starfish/image/_filter/util.py 83.33% <ø> (ø) ⬆️
starfish/types/__init__.py 100% <ø> (ø) ⬆️
starfish/types/_constants.py 97.82% <100%> (ø) ⬆️
starfish/image/_filter/white_tophat.py 100% <100%> (ø) ⬆️
starfish/test/image/test_apply.py 100% <100%> (ø) ⬆️
starfish/test/pipeline/test_filter.py 100% <100%> (ø) ⬆️
starfish/intensity_table/intensity_table.py 82.2% <100%> (ø) ⬆️
starfish/image/_filter/scale_by_percentile.py 100% <100%> (ø) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d6f2fb...e811268. Read the comment docs.

@ambrosejcarr ambrosejcarr force-pushed the ajc-move-preserve-float-range branch from 12adec9 to bb3634b Compare February 23, 2019 20:23
Copy link
Collaborator

@kevinyamauchi kevinyamauchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ambrosejcarr! Looks good to me. I didn't review the parts that are touched by other PRs (e.g., the new clipping stuff).

@ambrosejcarr ambrosejcarr force-pushed the ajc-move-preserve-float-range branch 2 times, most recently from 07cb43d to 4b8c85a Compare March 2, 2019 03:09
@ambrosejcarr ambrosejcarr force-pushed the ajc-linear-unmixing branch from ee3b463 to e811268 Compare March 2, 2019 04:29
@ambrosejcarr ambrosejcarr merged this pull request into ajc-move-preserve-float-range Mar 2, 2019
@ambrosejcarr ambrosejcarr deleted the ajc-linear-unmixing branch March 2, 2019 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants