-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linear Unmixing #1045
Linear Unmixing #1045
Conversation
c3ffbb9
to
d04cf81
Compare
Codecov Report
@@ Coverage Diff @@
## ajc-move-preserve-float-range #1045 +/- ##
==============================================================
Coverage 88.48% 88.48%
==============================================================
Files 164 164
Lines 6139 6139
==============================================================
Hits 5432 5432
Misses 707 707
Continue to review full report at Codecov.
|
d04cf81
to
ee3b463
Compare
12adec9
to
bb3634b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ambrosejcarr! Looks good to me. I didn't review the parts that are touched by other PRs (e.g., the new clipping stuff).
07cb43d
to
4b8c85a
Compare
Co-Authored-By: kevinyamauchi <kevin.yamauchi@gmail.com>
ee3b463
to
e811268
Compare
Based on #990
_unmix
method that is in [RFC] Add affine transform #990Opening a new PR so that @kevinyamauchi can take a look at the tests and make sure everything checks out without me force-pushing his branch.