Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[easy] move docker environment file to a subdirectory. #1084

Merged
merged 1 commit into from
Mar 15, 2019
Merged

[easy] move docker environment file to a subdirectory. #1084

merged 1 commit into from
Mar 15, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Mar 15, 2019

No description provided.

@ttung ttung requested a review from joshmoore March 15, 2019 17:39
@ttung ttung mentioned this pull request Mar 15, 2019
Merged
@codecov-io
Copy link

codecov-io commented Mar 15, 2019 •
edited
Loading

Codecov Report

Merging #1084 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1084   +/-   ##
=======================================
  Coverage   90.81%   90.81%           
=======================================
  Files         164      164           
  Lines        6151     6151           
=======================================
  Hits         5586     5586           
  Misses        565      565

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29012fc...1ad3a0b. Read the comment docs.

joshmoore
joshmoore approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for a nice and tidy top-level.

@ttung ttung merged commit ce318c1 into master Mar 15, 2019
@ttung ttung deleted the tonytung-docker branch March 15, 2019 18:36
ttung pushed a commit that referenced this pull request Mar 15, 2019
Use a pip config file. (#1085)
0394120 
This replaces #1080, and depends on #1084

Test plan: `make docker`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmoore joshmoore joshmoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttung @codecov-io @joshmoore