-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indirect File click types #1124
Conversation
Here's an example of how this works: |
b4d4832
to
a7fa8d1
Compare
a0fe12f
to
9a7ab47
Compare
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
=========================================
- Coverage 90.41% 88.62% -1.8%
=========================================
Files 125 130 +5
Lines 4550 4642 +92
=========================================
Hits 4114 4114
- Misses 436 528 +92
Continue to review full report at Codecov.
|
9a7ab47
to
5f51faf
Compare
5fd821e
to
c582dd5
Compare
503d218
to
69153e2
Compare
Add the ability to reference an imagestack or a codebook through a set of conversion recipes. Each conversion recipe can read the input given on the CLI and make an attempt to convert it to the desired type. For instance, a primary image can be referred to by the json describing the slicedimage set, _or_ @experiment.json[my_fov_name][primary].
69153e2
to
8c8c39a
Compare
I refactored this a bit to separate out the conversion logic from the click logic. Rationale: I want to be able to use this in the pipeline recipes. However, the recipes will not be able to use the click params, because at the time we generate the I will wait for this to be green before landing, but if you want to do a post-merge review, please do! :) |
Add the ability to reference an imagestack or a codebook through a set of conversion recipes. Each conversion recipe can read the input given on the CLI and make an attempt to convert it to the desired type.
For instance, a primary image can be referred to by the json describing the slicedimage set, or @experiment.json[my_fov_name][primary].