Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strict requirements #1142

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Update strict requirements #1142

merged 1 commit into from
Apr 8, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Apr 6, 2019

Test plan: make -j4 fast slow run-notebooks

@ttung ttung requested a review from shanaxel42 April 6, 2019 21:50
@codecov-io
Copy link

codecov-io commented Apr 6, 2019

Codecov Report

Merging #1142 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1142     +/-   ##
=========================================
- Coverage   67.62%   67.53%   -0.1%     
=========================================
  Files         132      132             
  Lines        4908     4903      -5     
=========================================
- Hits         3319     3311      -8     
- Misses       1589     1592      +3
Impacted Files Coverage Δ
starfish/compat.py 10.84% <0%> (-6.03%) ⬇️
starfish/spots/_detector/blob.py 94.23% <0%> (ø) ⬆️
starfish/test/full_pipelines/cli/test_iss.py 100% <0%> (ø) ⬆️
...h/spots/_detector/trackpy_local_max_peak_finder.py 66.66% <0%> (ø) ⬆️
starfish/util/click/__init__.py 40.74% <0%> (ø) ⬆️
starfish/spots/_detector/local_max_peak_finder.py 41.17% <0%> (ø) ⬆️
starfish/spots/_detector/detect.py 71.18% <0%> (+0.69%) ⬆️
starfish/spots/_detector/_base.py 90.38% <0%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82d69c...1d2ff70. Read the comment docs.

@ttung ttung mentioned this pull request Apr 7, 2019
Test plan: `make -j4 fast slow run-notebooks`
@ttung ttung merged commit 6c49568 into master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants