-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak master #1148
Unbreak master #1148
Conversation
1. Normalize the run(..) method with the contract specified in SpotFinderAlgorithmBase. 2. Flag an error if someone tries to specify a blobs_image with LocalSearchBlobDetector. 3. Temporarily provide a `image_to_spots` method which the SpotFinderAlgorithmBase requires. Test plan: `make -j fast`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if green.
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
+ Coverage 67.63% 88.4% +20.77%
==========================================
Files 132 132
Lines 4903 4907 +4
==========================================
+ Hits 3316 4338 +1022
+ Misses 1587 569 -1018
Continue to review full report at Codecov.
|
Notes | ||
----- | ||
blobs_image is an unused parameter that is included for testing purposes. It should not | ||
be passed to this method. If it is passed, the method will trigger a ValueError. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ambrosejcarr TRAILING WHITESPACE!! :)
image_to_spots
method which the SpotFinderAlgorithmBase requires.Test plan:
make -j fast