Rework physical coordinate calculation for max_proj #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttung
force-pushed
the
tonytung-max-proj-coords
branch
from
b7d02f9 to
8a9eb81
Compare
Codecov Report
@@ Coverage Diff @@
## master #1353 +/- ##
=========================================
+ Coverage 89.19% 89.2% +0.01%
=========================================
Files 148 148
Lines 5368 5374 +6
=========================================
+ Hits 4788 4794 +6
Misses 580 580
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-max-proj-coords
branch
2 times, most recently
from
7c80afe to
753d5dc
Compare
ttung
force-pushed
the
tonytung-max-proj-coords-base
branch
from
39c5fb0 to
25548ab
Compare
ttung
force-pushed
the
tonytung-max-proj-coords
branch
2 times, most recently
from
1234dbb to
65e59eb
Compare
ttung
force-pushed
the
tonytung-max-proj-coords-base
branch
from
3c72c4f to
9de6573
Compare
ttung
force-pushed
the
tonytung-max-proj-coords
branch
2 times, most recently
from
2068103 to
691c9a1
Compare
shanaxel42
approved these changes
May 17, 2019
ttung
force-pushed
the
tonytung-max-proj-coords-base
branch
from
4f72039 to
e31b3ba
Compare
ttung
force-pushed
the
tonytung-max-proj-coords
branch
3 times, most recently
from
ee3ac61 to
bc7b6b1
Compare
added 3 commits
May 23, 2019 11:14
ttung
force-pushed
the
tonytung-max-proj-coords
branch
from
bc7b6b1 to
ebd6b99
Compare
This was referenced May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on top of #1352 and #1291. The most likely path for this to get merged is for #1352 (and its supporting PRs) to land, rebase #1291 on top of master, and merging this all in.