Add the ability to write labeled experiments #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1374 +/- ##
==========================================
+ Coverage 89.2% 89.21% +<.01%
==========================================
Files 148 148
Lines 5373 5376 +3
==========================================
+ Hits 4793 4796 +3
Misses 580 580
Continue to review full report at Codecov.
|
shanaxel42
approved these changes
May 24, 2019
ttung
pushed a commit
that referenced
this pull request
May 31, 2019
Both `build_image` and `write_experiment_json` get an irregular flavor. In each case, the irregular case accepts an iterator of `TileCoordinate` objects, which record where the tile is in the 5D tensor. `build_image` and `write_experiment_json` internally call their irregular flavors because they are very generalized. #1374 introduced `write_labeled_experiment_json`, and this replaces that operation. We are not deprecating that API because it never made it into a release; we will simply replace it. Test plan: travis Fixes #1322
ttung
pushed a commit
that referenced
this pull request
Jun 6, 2019
Both `build_image` and `write_experiment_json` get an irregular flavor. In each case, the irregular case accepts an iterator of `TileCoordinate` objects, which record where the tile is in the 5D tensor. `build_image` and `write_experiment_json` internally call their irregular flavors because they are very generalized. #1374 introduced `write_labeled_experiment_json`, and this replaces that operation. We are not deprecating that API because it never made it into a release; we will simply replace it. Test plan: travis Fixes #1322
ttung
pushed a commit
that referenced
this pull request
Jun 6, 2019
Both `build_image` and `write_experiment_json` get an irregular flavor. In each case, the irregular case accepts an iterator of `TileCoordinate` objects, which record where the tile is in the 5D tensor. `build_image` and `write_experiment_json` internally call their irregular flavors because they are very generalized. #1374 introduced `write_labeled_experiment_json`, and this replaces that operation. We are not deprecating that API because it never made it into a release; we will simply replace it. Test plan: travis Fixes #1322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this for the generalized experiment formatter (#1318), and @njmei needs it for #1322.
Test plan:
pytest -v -n4 starfish/core/experiment/builder/test/