Add custom clip Filter classes #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1376 +/- ##
==========================================
+ Coverage 89.4% 89.49% +0.08%
==========================================
Files 149 151 +2
Lines 5416 5481 +65
==========================================
+ Hits 4842 4905 +63
- Misses 574 576 +2
Continue to review full report at Codecov.
|
ttung
approved these changes
May 30, 2019
This is a combination of 2 commits: 1) This commit adds two custom clip `Filter` classes called: ClipValueToZero and ClipPercentileToZero They operate by clipping to a minimum value (or min percentile value) and then subtracting the entire image with that minimum value. 2) Fix whitespace and type annotations
|
Okay, should be ready for merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two custom clip
Filterclasses called:ClipValueToZero and ClipPercentileToZero
They operate by clipping to a minimum value (or min percentile value)
and then subtracting the entire image with that minimum value.
This will allow us to create/run recipes for our pipeline(s).