updated loading-data docs and added image of napari viewer #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1387 +/- ##
=======================================
Coverage 89.47% 89.47%
=======================================
Files 152 152
Lines 5494 5494
=======================================
Hits 4916 4916
Misses 578 578Continue to review full report at Codecov.
|
|
|
||
| Typing the above code should display an image viewer that looks something like this:, | ||
|
|
||
| #TODO ambrosejcarr annotate an image of the napari viewer. | ||
| .. image:: /_static/design/napari-viewer.png |
There was a problem hiding this comment.
I get a 404 on the github rendering of this image. Can you verify that it shows up on the docs you build locally? If that works for you then I think this is good to merge. 👍
There was a problem hiding this comment.
This is what I get locally
ambrosejcarr
approved these changes
Jun 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit a few minor bugs when going through the getting-started docs and this is how I fixed them