Update in-place experiment writing to use the new WriterContract API in slicedimage 4.0.0 #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttung
force-pushed
the
tonytung-new-inplace
branch
from
53c97aa to
800c651
Compare
|
I get an |
|
@njmei I made a mistake in an earlier refactor. spacetx/slicedimage#110 |
njmei
reviewed
Jul 12, 2019
|
|
||
| Please note that enabling in-place experiment construction should be only done in an isolated script | ||
| dedicated to constructing an experiment, as it modifies some existing code paths. | ||
| 1. Call write_experiment_json with writer_contract=InplaceWriterContract. |
There was a problem hiding this comment.
Should be:
writer_contract=InplaceWriterContract()
shanaxel42
approved these changes
Jul 15, 2019
| if fov_path_generator is not None or tile_opener is not None: | ||
| warnings.warn( | ||
| "`fov_path_generator` and `tile_opener` options for writing experiment files is " | ||
| "deprecated. Use `riter_contract` instead.", |
There was a problem hiding this comment.
Suggested change
| "deprecated. Use `riter_contract` instead.", | |
| "deprecated. Use `writer_contract` instead.", |
ttung
force-pushed
the
tonytung-new-inplace
branch
from
800c651 to
6411db3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1447 +/- ##
=========================================
- Coverage 89.78% 89.7% -0.08%
=========================================
Files 161 161
Lines 5972 5956 -16
=========================================
- Hits 5362 5343 -19
- Misses 610 613 +3
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-new-inplace
branch
2 times, most recently
from
218d64e to
b12514a
Compare
…in slicedimage 4.0.0 Test plan: in-place experiment writing tests pass.
ttung
force-pushed
the
tonytung-new-inplace
branch
from
b12514a to
e464306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: in-place experiment writing tests pass.
Note that travis won't succeed until spacetx/slicedimage#109 is approved and released.