-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.) refactoring localMaxPeakFinder/osmFIsh #1594
Conversation
Codecov Report
@@ Coverage Diff @@
## fix-branch #1594 +/- ##
==============================================
- Coverage 87.57% 86.11% -1.46%
==============================================
Files 153 155 +2
Lines 5392 5438 +46
==============================================
- Hits 4722 4683 -39
- Misses 670 755 +85
Continue to review full report at Codecov.
|
be8e35a
to
b89c389
Compare
3d96b11
to
b0ca097
Compare
82c7dc2
to
9c710e5
Compare
b0ca097
to
27698d6
Compare
fac9141
to
f46d2ca
Compare
f46d2ca
to
64ea392
Compare
default 'max' calculates the maximum intensity inside the object | ||
min_num_spots_detected : int | ||
When fewer than this number of spots are detected, spot searching for higher threshold | ||
values. (default = 3) | ||
is_volume : bool | ||
Not supported. For 3d peak detection please use TrackpyLocalMaxPeakFinder. | ||
(default=False) | ||
verbose : bool | ||
If True, report the percentage completed (default = False) during processing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inconsistent depiction of defaults.
# stop spot finding when the number of detected spots falls below min_num_spots_detected | ||
if len(spots) <= self.min_num_spots_detected: | ||
stop_threshold = threshold | ||
if self.verbose: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly out of the scope of this PR, but this test of verbosity differs from the above one.
|
||
Returns | ||
------- | ||
Number : #TODO ambrosejcarr this should probably be a float |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, which is it, @ambrosejcarr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
float.
9c44352
to
879f771
Compare
5ff0e1c
to
facfd14
Compare
1d254d9
to
ff7d5f7
Compare
ff7d5f7
to
ba6d3be
Compare
402245d
to
b4eb1b5
Compare
02bce4a
to
e116567
Compare
b4eb1b5
to
c25bbee
Compare
This PR:
depends on: #1593 #1592 #1518 #1517