Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.) refactoring localMaxPeakFinder/osmFIsh #1594

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

shanaxel42
Copy link
Collaborator

@shanaxel42 shanaxel42 commented Oct 1, 2019

This PR:

  • adds a new version of LocalMaxPeakFinder to the FindSpots module that processes SpotFindingResults
  • Refactors osmFish to use FindSpots.LocalMaxPeakFinder and DecodeSpots.PerRoundMaxChannel with a trace building strategy of SEQUENTIAL

depends on: #1593 #1592 #1518 #1517

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #1594 into fix-branch will decrease coverage by 1.45%.
The diff coverage is 27.41%.

Impacted file tree graph

@@              Coverage Diff               @@
##           fix-branch    #1594      +/-   ##
==============================================
- Coverage       87.57%   86.11%   -1.46%     
==============================================
  Files             153      155       +2     
  Lines            5392     5438      +46     
==============================================
- Hits             4722     4683      -39     
- Misses            670      755      +85
Impacted Files Coverage Δ
starfish/core/spots/FindSpots/__init__.py 100% <100%> (ø) ⬆️
starfish/core/spots/DecodeSpots/__init__.py 100% <100%> (ø) ⬆️
...fish/core/spots/FindSpots/local_max_peak_finder.py 22.54% <22.54%> (ø)
starfish/core/spots/DecodeSpots/metric_decoder.py 45% <45%> (ø)
...arfish/core/segmentation_mask/segmentation_mask.py 94.56% <0%> (-1.82%) ⬇️
starfish/core/spots/DetectSpots/detect.py 98.36% <0%> (-0.15%) ⬇️
starfish/core/errors.py 100% <0%> (ø) ⬆️
starfish/core/imagestack/imagestack.py 93.69% <0%> (+0.68%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e116567...83059fc. Read the comment docs.

Comment on lines 36 to 44
default 'max' calculates the maximum intensity inside the object
min_num_spots_detected : int
When fewer than this number of spots are detected, spot searching for higher threshold
values. (default = 3)
is_volume : bool
Not supported. For 3d peak detection please use TrackpyLocalMaxPeakFinder.
(default=False)
verbose : bool
If True, report the percentage completed (default = False) during processing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inconsistent depiction of defaults.

# stop spot finding when the number of detected spots falls below min_num_spots_detected
if len(spots) <= self.min_num_spots_detected:
stop_threshold = threshold
if self.verbose:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly out of the scope of this PR, but this test of verbosity differs from the above one.


Returns
-------
Number : #TODO ambrosejcarr this should probably be a float
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, which is it, @ambrosejcarr?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

float.

@shanaxel42 shanaxel42 merged commit 1623205 into fix-branch Oct 15, 2019
shanaxel42 pushed a commit that referenced this pull request Oct 15, 2019
* refactoring allen smFish with new spot finding

* 5.) refactoring localMaxPeakFinder/osmFIsh (#1594)

* refactoring localMaxPeakFinder

* adding MetricDecoder to DecodeSpots (#1596)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants