8.) delete old detect code #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1598 +/- ##
==========================================
- Coverage 90.09% 89.87% -0.23%
==========================================
Files 234 219 -15
Lines 8764 8117 -647
==========================================
- Hits 7896 7295 -601
+ Misses 868 822 -46
Continue to review full report at Codecov.
|
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
3 times, most recently
from
c5119e3
to
f04f3a8
Compare
shanaxel42
force-pushed
the
saxelrod-change-test-code
branch
from
7641be8
to
e6faede
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
f04f3a8
to
2e83d51
Compare
shanaxel42
force-pushed
the
saxelrod-change-test-code
branch
from
e6faede
to
dd3c52b
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
2e83d51
to
5c05508
Compare
shanaxel42
force-pushed
the
saxelrod-change-test-code
branch
from
dd3c52b
to
77e325b
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
5c05508
to
31a6633
Compare
shanaxel42
force-pushed
the
saxelrod-change-test-code
branch
from
77e325b
to
ec4ae04
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
2 times, most recently
from
a1146ed
to
4bab8a6
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
4bab8a6
to
e256f23
Compare
shanaxel42
force-pushed
the
saxelrod-change-test-code
branch
from
80edf85
to
e2b9552
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
6 times, most recently
from
cfc715f
to
48fb35f
Compare
ttung
approved these changes
Oct 9, 2019
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
3 times, most recently
from
95da868
to
7e0f702
Compare
shanaxel42
force-pushed
the
saxelrod-change-test-code
branch
from
2be9972
to
da59228
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
7e0f702
to
a67db56
Compare
shanaxel42
force-pushed
the
saxelrod-change-test-code
branch
from
da59228
to
c6d4cff
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
a67db56
to
a496f53
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
2 times, most recently
from
954b4d0
to
a75759b
Compare
shanaxel42
force-pushed
the
saxelrod-change-test-code
branch
from
3f8ab94
to
4edbbed
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
a75759b
to
2422242
Compare
shanaxel42
force-pushed
the
saxelrod-change-test-code
branch
from
4edbbed
to
e3451b7
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
2422242
to
c2aa606
Compare
shanaxel42
force-pushed
the
saxelrod-change-test-code
branch
from
e3451b7
to
fba9259
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
3 times, most recently
from
f3e7e24
to
8f72169
Compare
shanaxel42
force-pushed
the
saxelrod-change-test-code
branch
from
8d14199
to
8b844f2
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
2 times, most recently
from
1e62cbe
to
bf6dd05
Compare
shanaxel42
force-pushed
the
saxelrod-change-test-code
branch
from
8b844f2
to
1aa3b42
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
bf6dd05
to
52e5912
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
52e5912
to
7e24890
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
7e24890
to
d0e97c4
Compare
shanaxel42
force-pushed
the
saxelrod-delete-old-detect-code
branch
from
d0e97c4
to
8c0b6ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deletes all the old Detect code and references to it in the documentation. It should be merged after a version of starfish has been released with the deprecation warnings.