Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build #1608

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Fix broken build #1608

merged 1 commit into from
Oct 9, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Oct 9, 2019

In #1540, I missed a conversion from Reduce.FunctionSource to types.FunctionSource.

@ttung ttung requested a review from shanaxel42 October 9, 2019 23:23
@ttung
Copy link
Collaborator Author

ttung commented Oct 9, 2019

I'm going to land this to unbreak master. #shame

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9592539). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1608   +/-   ##
=========================================
  Coverage          ?   88.04%           
=========================================
  Files             ?      150           
  Lines             ?     5143           
  Branches          ?        0           
=========================================
  Hits              ?     4528           
  Misses            ?      615           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9592539...757bc08. Read the comment docs.

In #1540, I missed a conversion from Reduce.FunctionSource to types.FunctionSource.
@ttung ttung merged commit c9957ea into master Oct 9, 2019
@ttung ttung deleted the tonytung-fix-build branch October 9, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants