Don't fill a new ImageStack with NaN #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
==========================================
- Coverage 88.04% 88.04% -0.01%
==========================================
Files 155 155
Lines 5455 5454 -1
==========================================
- Hits 4803 4802 -1
Misses 652 652
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-no-fill
branch
5 times, most recently
from
0d1883d
to
e82b7b9
Compare
ttung
force-pushed
the
tonytung-no-fill
branch
from
e82b7b9
to
127aee9
Compare
We've used this codepath enough that it's reasonably safe to assume that it'll work. This avoids the allocation of memory until the data is actually filled in. Test plan: travis.
ttung
force-pushed
the
tonytung-no-fill
branch
from
127aee9
to
ae718c3
Compare
shanaxel42
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've used this codepath enough that it's reasonably safe to assume that it'll work. This avoids the allocation of memory until the data is actually filled in.
Test plan: travis.