Make regionprops available per mask #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1610 +/- ##
==========================================
+ Coverage 88.04% 88.04% +<.01%
==========================================
Files 155 155
Lines 5438 5455 +17
==========================================
+ Hits 4788 4803 +15
- Misses 650 652 +2
Continue to review full report at Codecov.
|
shanaxel42
approved these changes
Oct 15, 2019
ttung
force-pushed
the
tonytung-regionprops
branch
from
f631229 to
f9189b5
Compare
regionprops are useful to characterize and filter segmented cells. This PR changes what we store for mask data to be a tuple of binary mask and regionprops. If we construct a mask collection from a labeled image, we retain the region props that are automatically calculated as a part of this conversion process. If we construct a mask collection from what's stored on disk, we will calculate the regionprops when requested. Test plan: Save to disk a mask collection generated from a labeled image, and after loading it from disk, verify that the region props of the two mask collections match. Part of #1497
ttung
force-pushed
the
tonytung-regionprops
branch
from
f9189b5 to
3429923
Compare
ttung
pushed a commit
that referenced
this pull request
Oct 18, 2019
We will use BinaryMaskCollection for other useful purposes, where it may not necessarily be the product of segmentation. Test plan: travis. Depends on #1610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regionprops are useful to characterize and filter segmented cells. This PR changes what we store for mask data to be a tuple of binary mask and regionprops. If we construct a mask collection from a labeled image, we retain the region props that are automatically calculated as a part of this conversion process. If we construct a mask collection from what's stored on disk, we will calculate the regionprops when requested.
Test plan: Save to disk a mask collection generated from a labeled image, and after loading it from disk, verify that the region props of the two mask collections match.
Part of #1497