Fix install issues #1641
Merged
Fix install issues #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of botocore caps python-dateutil at 2.8.0. Unfortunately, if another package has already declared an unversioned dependency on python-dateutil, 2.8.1 is installed. Later on, when botocore is installed, it blows up and install fails. This adds a temporary (hopefully) restriction to match botocore's requirement so that we can successfully install. Test plan: `pip install -e .` without any angry errors.
shanaxel42
approved these changes
Nov 7, 2019
Merged
ttung
pushed a commit
that referenced
this pull request
Nov 13, 2019
It simply overlays a python image 3.6 image with a starfish install. No weird conda bugs. It will be fantastic. Changed the entry point so that it's just a bash shell. Depends on #1641 Test plan: `make docker`
ttung
pushed a commit
that referenced
this pull request
Nov 13, 2019
It simply overlays a python image 3.6 image with a starfish install. No weird conda bugs. It will be fantastic. Changed the entry point so that it's just a bash shell. Depends on #1641 Test plan: `make docker`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of botocore caps python-dateutil at 2.8.0. Unfortunately, if another package has already declared an unversioned dependency on python-dateutil, 2.8.1 is installed. Later on, when botocore is installed, it blows up and install fails.
This adds a temporary (hopefully) restriction to match botocore's requirement so that we can successfully install.
Test plan:
pip install -e .without any angry errors.